Sync service crashes when updated row matches where clause of the shape

[jo16oh]

Hi all 👋
I've been playing around with electric-next for a while and encountered error described in the title.

How to reproduce

sync service version : 0.3.3

1. Create table

CREATE TABLE foo (
  id SERIAL PRIMARY KEY,
  name VARCHAR(255),
  value FLOAT
);

INSERT INTO foo (name, value) VALUES
  ('Alice', 3.14),
  ('Bob', 2.71),
  ('Charlie', -1.618),
  ('David', 1.414),
  ('Eve', 0);

2. Establish connection

const stream = new ShapeStream({
	url: `http://localhost:3000/v1/shape/foo`,
	where: "name = 'Bob'",
});

3. Update existing row

UPDATE foo SET name = 'Bob' WHERE name = 'Alice';

4. Then it crashes!

[alco]

Hey @jo16oh 👋

Please specify the server and client versions you are using. It would be helpful if you could share a small repo that reproduces the problem.

I've just tried reproducing it using the latest versions of the client and the server and it's working fine here. The client receives two messages from the server and switches to the live mode:

{
  offset: '0_0',
  value: { id: 2, name: 'Bob', value: 2.71 },
  key: '"public"."foo"/"2"',
  headers: { operation: 'insert' }
}
{ headers: { control: 'up-to-date' } }

[alco]

Sorry, spoke too soon. I do get an error in the server log:

15:53:35.027 [info] Received transaction 750 from Postgres at 0/19B49A8

15:53:35.027 [debug] Txn received: %Electric.Replication.Changes.Transaction{xid: 750, commit_timestamp: ~U[2024-08-23 12:53:34.502940Z], lsn: #Lsn<0/19B49A8>, last_log_offset: LogOffset.new(26954104, 0), changes: [%Electric.Replication.Changes.UpdatedRecord{relation: {"public", "foo"}, old_record: %{"id" => "1", "name" => "Alice", "value" => "3.14"}, record: %{"id" => "1", "name" => "Bob", "value" => "3.14"}, log_offset: LogOffset.new(26954104, 0), key: nil, old_key: nil, tags: [], changed_columns: MapSet.new(["name"])}], affected_relations: MapSet.new([{"public", "foo"}])}

15:53:35.028 [error] GenServer Electric.Replication.ShapeLogCollector terminating
** (FunctionClauseError) no function clause matching in Electric.Replication.LogOffset.to_tuple/1
    (electric 0.3.3) lib/electric/replication/log_offset.ex:159: Electric.Replication.LogOffset.to_tuple(nil)
    (electric 0.3.3) lib/electric/shape_cache/cub_db_storage.ex:198: Electric.ShapeCache.CubDbStorage.log_key/2
    (electric 0.3.3) lib/electric/shape_cache/cub_db_storage.ex:163: anonymous fn/2 in Electric.ShapeCache.CubDbStorage.append_to_log!/3
    (elixir 1.17.2) lib/enum.ex:1703: Enum."-map/2-lists^map/1-1-"/2
    (electric 0.3.3) lib/electric/shape_cache/cub_db_storage.ex:163: Electric.ShapeCache.CubDbStorage.append_to_log!/3
    (electric 0.3.3) lib/electric/shape_cache.ex:102: Electric.ShapeCache.append_to_log!/4
    (electric 0.3.3) lib/electric/replication/shape_log_collector.ex:109: anonymous fn/9 in Electric.Replication.ShapeLogCollector.handle_call/3
    (elixir 1.17.2) lib/enum.ex:2531: Enum."-reduce/3-lists^foldl/2-0-"/3
    (electric 0.3.3) lib/electric/replication/shape_log_collector.ex:90: Electric.Replication.ShapeLogCollector.handle_call/3
    (stdlib 6.0.1) gen_server.erl:2209: :gen_server.try_handle_call/4
    (stdlib 6.0.1) gen_server.erl:2238: :gen_server.handle_msg/6
    (stdlib 6.0.1) proc_lib.erl:329: :proc_lib.init_p_do_apply/3
Last message (from #PID<0.973.0>): {:new_txn, %Electric.Replication.Changes.Transaction{xid: 750, commit_timestamp: ~U[2024-08-23 12:53:34.502940Z], lsn: #Lsn<0/19B49A8>, last_log_offset: LogOffset.new(26954104, 0), changes: [%Electric.Replication.Changes.UpdatedRecord{relation: {"public", "foo"}, old_record: %{"id" => "1", "name" => "Alice", "value" => "3.14"}, record: %{"id" => "1", "name" => "Bob", "value" => "3.14"}, log_offset: LogOffset.new(26954104, 0), key: nil, old_key: nil, tags: [], changed_columns: MapSet.new(["name"])}], affected_relations: MapSet.new([{"public", "foo"}])}}
State: %{name: Electric.Replication.ShapeLogCollector, registry: Registry.ShapeChanges, shape_cache: {Electric.ShapeCache, [storage: {Electric.ShapeCache.CubDbStorage, %{version: 1, file_path: "./shapes", db: :shape_db}}, prepare_tables_fn: {Electric.Postgres.Configuration, :configure_tables_for_replication!, ["electric_publication"]}]}, inspector: {Electric.Postgres.Inspector.EtsInspector, [server: Electric.Postgres.Inspector.EtsInspector]}}
Client #PID<0.973.0> is alive

[jo16oh]

It might not help but just to be clear, here's my environment:
- sync-service 0.3.3 (running on docker)
- client: 0.3.1
- Macbook Air M1 16GB / macOS Sonoma 14.6.1

[alco]

This has been fixed in #1589. You can give it try by pulling the latest electricsql/electric:canary image.

[jo16oh]

That's working as expected now! Thank you for the quick fix 😊