-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Details about the bot creating/updating "parser down" issues #7675
Comments
I think the bot is running once per day, so it should close the issue by tomorrow since I made a new release today.
When PRs are merged to master in this repository a automated PR is created against our monorepo that contains all changes since the last release and then run all integration tests in the backend against it and ensure all our dependencies are in sync. This PR requires manual approval and merging to create a new automated release.
This is for the frontend only, at least for now, when we do backend changes we usually just version them and run them in parallel with the old version. I hope this makes some sense. BTW part of the reason the bot only runs once per day is to avoid some flakiness and the fact that it's looking at the incoming data instead of parser errors, so sometimes (like for Italy) it means the data is unavailable but the parser is technically working. |
@VIKTORVAV99 is the automation doing this something I could look at or be extracted to be made public, and something I could contribute to? I'm not sure how the automation is made, but it could be made very easily using a github workflow - and if its already a github workflow, I have a lot of know-how about working it. Top of the head improvement ideas:
|
It's in our internal monorepo now so it's not a decision I can make alone, but I'll ask and see what the others say. It's currently running in a Google Cloud instance with access to our database so not sure how easy it would be to migrate. |
I think improving that automation is quite essential to drive this project with regards to parser development. I think the key things I look to have contributing to the parsers currently are:
I'm happy to help with this in general in any way I can, I've freed up time in my life to work on things I think matters. I have gained some relevant know-how for this kind of work via maintenance of cloud infra in the public on github (https://github.com/jupyterhub/mybinder.org-deploy, https://github.com/2i2c-org/infrastructure), and have a lot of cloud know how in general. |
I saw that the "SV parser down" issue #5158 is still open, even though its functional now, so I'm asking a few questions that I can't figure out myself as I think its closed source.
Knowledge about this can help me debug and understand "parser down" issues in general, and I'm interested in working on resolving them.
The text was updated successfully, but these errors were encountered: