Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making this process better #531

Open
ameerthehacker opened this issue Feb 26, 2018 · 8 comments
Open

Making this process better #531

ameerthehacker opened this issue Feb 26, 2018 · 8 comments

Comments

@ameerthehacker
Copy link

I feel like we can have a website which has a dedicated way to add apps and details without making a pull request. This would be quick and fast and we can ad much more features like ratings download counter etc. If anyone is interested in this idea I would like to create that site for electron putting my entire heart and sole ❤️ . Waiting for your reply.

@zeke
Copy link
Contributor

zeke commented Feb 26, 2018

Yep, good point. This project has grown organically, and a web-based form for adding apps does seem like a nice improvement.

A few ideas:

  • On the form, ask for repo first and automatically fill in description, website, name, etc
  • Support "login with GitHub" and autodetect Electron apps owned by the logged-in user.
  • We'd probably need a database. PostgreSQL, Redis, or something...

@ameerthehacker
Copy link
Author

Exactly but how should i get started? This would be a big change to the site and is that ok and doing this in one pull request does not seem right way for me so i would be great help if you can give your thoughts on this.

@zeke
Copy link
Contributor

zeke commented Feb 26, 2018

Yeah honestly I feel like this would be a pretty big undertaking for an outside contributor.

@MarshallOfSound, you were working on something related to this. What came of that? Any thoughts on how it should work?

@MarshallOfSound
Copy link
Member

I still have the code somewhere, I got to the point where I was inferring default values from a repository and was making progress towards automatically making a PR for the users app. When I get a chance I'll resurrect the code from whatever stash it is sitting in and push it up so others can maybe finish off the work

@ameerthehacker
Copy link
Author

Great, but will it be a problem if I can start things from scratch and start pushing minor updates step by step. This is the roadmap which I feel might work.

  1. Create login with Github
  2. Get the default values from repo
  3. Store those things in the database
  4. Upload the downloadables to a S3 bucket or something similar
  5. Making sure backward compatibility for the older apps and the apps being newly added.

@MarshallOfSound
Copy link
Member

@ameerthehacker I don't think we want to move away from storing everything in a GitHub repo, it allows for versioning/tracking/history we won't get from an S3 bucket. Steps 1-3 I already have somewhere with local code and step 4 is what I stopped working on just instead of sending to S3 I was making it auto-PR to github. I'll figure out which laptop had the code on it some time this week if I get a chance

@ameerthehacker
Copy link
Author

Fine @MarshallOfSound I will be waiting for it

@zeke zeke changed the title Making this process more better Making this process better Mar 4, 2018
@rustdevbtw
Copy link
Contributor

rustdevbtw commented Mar 26, 2022

@MarshallOfSound Is there any progress on it? What about a dashboard that will trigger the electron-bot to add the app to the repo (with a direct commit or PR) after an app is reviewed? And after the PR is merged, it'll automatically add that app to the meta files and rebuild the https://www.electronjs.org website. This repo will still be the centralised place for all apps but a Dashboard will actually make the process better and easier - both for reviewers and developers.

Also, a database might be needed, I prefer the new Appwrite Backend-As-A-Service as it's a modern and highly scalable solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants