Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive rmdir returns error while trying to remove folder, that contains asar file. #297

Closed
tangjfn opened this issue Jan 11, 2024 · 1 comment

Comments

@tangjfn
Copy link

tangjfn commented Jan 11, 2024

electron version 28.1.3
v27.2.2 is OK

// const fs = require("original-fs"); // same error thrown
await fs.promises.rm("path contains asar file",{force: true, recursive: true})
// throw a error ENOTEMPTY: directory not empty, rmdir '...'
test.zip
extract test.zip to a dir
cd the dir
electron .
input a dir contains any asar file
click rm button

@erikian
Copy link
Member

erikian commented Jan 16, 2024

Thanks for the issue report! This is probably an issue on Electron's side, and it's not related to the @electron/asar package. I've opened a new issue in Electron (electron/electron#41008) using the test case you've provided so we can investigate it further, you can follow that issue for any new developments.

@erikian erikian closed this as completed Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants