Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acyclic motions conditioning #2

Open
Gabriel-Bercaru opened this issue Aug 11, 2021 · 1 comment
Open

Acyclic motions conditioning #2

Gabriel-Bercaru opened this issue Aug 11, 2021 · 1 comment

Comments

@Gabriel-Bercaru
Copy link

Hello,

In the article corresponding to this repository, in section 7.4 Acyclic Motions, is is mentioned an idea about additionally conditioning the VAE model. It is said that it can generate the next frame considering a one-hot encoding of an acyclic action like kick or header.

I have gone through the repository code, but I might have missed this part. As far as I have seen, at least for the default model (Mixture VAE), the encoder only conditions on the given number of previous frames (https://github.com/electronicarts/character-motion-vaes/blob/main/vae_motion/models.py#L87). Did I miss this additional conditioning part or it was not included in current state of the repository?

Thank you!

@belinghy
Copy link

Sorry for the late response.

You’re right — you haven’t missed it, it’s not in the current state of the repository. The acyclic motion experiments were late additions to the paper (suggested by reviewers), and so didn’t make it to the code release.

We chose the easiest implementation that we could come up. In L87 of the encoder, the frame_size would be larger, as it would contain the one-hot vector as well as the pose. By treating the one-hot vector as part of the condition, we can implement it with minimal code changes. The decoder can be similarly modified. When training RL controller or at test time, we would force the condition vector to be a certain action by blending the one-hot vector with the desired action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants