Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to remove call from recents #2618

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Sep 10, 2024

This adds a button on each recent call tile to allow removing it.

Fixes: #2243

Screenshot 2024-09-10 at 13 31 44

The trash can IconButton from compound is the least obtrusive option I could think of. It could be made even less obtrusive by only displaying it on hover but I wasn't sure if that's really needed.

I didn't set the destructive property because while semantically true, it makes the button very prominent, especially when you have several tiles on the screen. Maybe destructive={true} could be combined with only showing the button on hover though.

Screenshot 2024-09-10 at 13 37 59

One small annoyance is that because the IconButton is inside the Link, the browser will show the link target when hovering the button. This felt better than reducing the tile's click target though.

@CLAassistant
Copy link

CLAassistant commented Sep 10, 2024

CLA assistant check
All committers have signed the CLA.

@fkwp
Copy link
Contributor

fkwp commented Sep 10, 2024

cool -- really nice. @amshakal wdyt ?

@amshakal
Copy link

Oh hello there! :)
This is definitely a desirable feature. I was wondering if we could change the icon to the one shared below. The reason for that is to make it more cohesive with the rest of the element call designs. Happy to provide the icon in any file format that might be needed. SVG perhaps?
Screenshot 2024-09-10 at 2 15 42 PM

Close button

@Johennes
Copy link
Contributor Author

👋🙂

This is definitely a desirable feature. I was wondering if we could change the icon to the one shared below. The reason for that is to make it more cohesive with the rest of the element call designs. Happy to provide the icon in any file format that might be needed. SVG perhaps?

This looks like the close icon from compound. Just pushed a change to use that instead of the trash can. How does that look?

Screenshot 2024-09-10 at 16 22 10

@amshakal
Copy link

Perfect 👌👌👌

Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition.
This is almost ready. Once the useTranslation change is done I can approve it.
The other change is optional but I would be really happy and thankful if invest the time because you also think its an improvement.

src/home/CallList.tsx Outdated Show resolved Hide resolved
src/home/CallList.tsx Outdated Show resolved Hide resolved
@fkwp fkwp merged commit eb6719d into element-hq:livekit Sep 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove entries from previous call list
5 participants