Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix.to and iOS permalinks mismatch #7572

Closed
ghost opened this issue Jun 2, 2023 · 4 comments
Closed

matrix.to and iOS permalinks mismatch #7572

ghost opened this issue Jun 2, 2023 · 4 comments
Labels
support Support request

Comments

@ghost
Copy link

ghost commented Jun 2, 2023

Steps to reproduce

  1. Where are you starting? What can you see?
  2. What do you click?
  3. More steps…

Outcome

What did you expect?

matrix.to generates permalink in the following format: https://matrix.to/#/@name:domain.example
I expected the iOS app to use the same format for it's Invite links generator.

What happened instead?

No matter if I specify the default matrix.to or a custom instance in the iOS build settings, the app adds an extra part to the link, so its https://matrix.to/#**/user/**@name:domain.example

I'm not getting how can I change the generated link for the iOS build to remove this unneeded /user entry.
Would appreciate an advice.

Your phone model

No response

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@ghost ghost added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jun 2, 2023
@ghost ghost changed the title matrix.to and iOS links mismatch matrix.to and iOS permalinks mismatch Jun 2, 2023
@Velin92
Copy link
Member

Velin92 commented Jun 12, 2023

The value seems to be actually handled by the Matrix iOS SDK here: https://github.com/matrix-org/matrix-ios-sdk/blob/43cf8b34b5978c0180626db6ad978f6c3b9ca822/MatrixSDK/Utils/MXTools.m#L666

@Velin92 Velin92 added support Support request and removed T-Defect Something isn't working: bugs, crashes, hangs and other reported problems labels Jun 12, 2023
@ghost
Copy link
Author

ghost commented Jun 12, 2023

@Velin92 thanks for your help. It's really surprising Matrix iOS SDK adds /user to links by design, it affects "Invite Friends" option for all iOS devices, no matter which matrix.to intance is used.

@Velin92
Copy link
Member

Velin92 commented Jun 12, 2023

No problem! Can I close the issue? Or you want to actually report a specific issue regarding this permalink?
If so could you provide the steps to reproduce it and the expected/received outcome?

@ghost
Copy link
Author

ghost commented Jun 12, 2023

As it's caused by Matrix SDK, I reported the issue there.
It's being easily reproduced by trying to visit the invitation permalink created in iOS app.

Closing it

@ghost ghost closed this as completed Jun 12, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support Support request
Projects
None yet
Development

No branches or pull requests

1 participant