Skip to content

add package-lock needed for dbt 1.8 in read-only deployments#1669

Closed
noel wants to merge 1 commit intoelementary-data:masterfrom
datacoves:ng_fix_packages_lock
Closed

add package-lock needed for dbt 1.8 in read-only deployments#1669
noel wants to merge 1 commit intoelementary-data:masterfrom
datacoves:ng_fix_packages_lock

Conversation

@noel
Copy link
Copy Markdown

@noel noel commented Aug 12, 2024

When elementary is installed on a docker image in a read-only folder, dbt deps are run and that will generate a packages-lock file. The way to solve the packages issue is to include the lock file in the project. This PR will address this issue. The issue here is similar as it is related to running dbt deps in a read-only folder.

With this change, edr commands can be run as follows to address both issues.

               mkdir /tmp/elementary
                export DBT_TARGET_PATH=/tmp/elementary &&
                export DBT_PACKAGES_FOLDER=/tmp/elementary &&
                edr send-report --days-back 60

@FrankTub
Copy link
Copy Markdown
Contributor

FrankTub commented Sep 9, 2024

This would be really helpful!

@noel
Copy link
Copy Markdown
Author

noel commented Sep 29, 2024

Bumping this. Are you planning to make elementary dbt 1.8 compliant?

@haritamar
Copy link
Copy Markdown
Collaborator

Hi @noel !
Just merged these changes in a separate PR (needed to tweak a bit and add a pre-commit verification to the lock), this change will be included in the upcoming release.

Cheers,
Itamar

@haritamar haritamar closed this Nov 18, 2024
@sfortrie
Copy link
Copy Markdown

Hi @noel ! Just merged these changes in a separate PR (needed to tweak a bit and add a pre-commit verification to the lock), this change will be included in the upcoming release.

Cheers, Itamar

@haritamar : which PR? Is it already included in a recent release ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants