Take presence of hidden files into account when showing empty message #2662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
For some reason the diff is not showing all changes - only last commit?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1278
The chosen solution is to add another label to the existing
empty_labelwhich shows when there are no visible files but the folder contains undisplayed hidden files.The original message now displays when the
modelis empty (i.e. the view would be blank). If the model is empty but the folder is not empty then hidden files are present and an addition label is shown with this information.To reduce the performance hit when pasting or deleting a large number of files (which is already slow) the update function is throttled. Ideally we would want to implement batch file operations but that will have to wait for Gtk4