BackgroundManager: Send changed signal early (#1968)

lenemter · web-flow · commit 5c420862d1c3 · 2024-07-08T21:13:10.000Z
diff --git a/src/Background/BackgroundManager.vala b/src/Background/BackgroundManager.vala
@@ -49,13 +49,13 @@ public class Gala.BackgroundManager : Meta.BackgroundGroup, Gala.BackgroundManag
         }
     }
 
-    private void swap_background_actor (bool animate) {
-        return_if_fail (new_background_actor != null);
-
+    private void swap_background_actor (bool animate) requires (new_background_actor != null) {
         var old_background_actor = background_actor;
         background_actor = new_background_actor;
         new_background_actor = null;
 
+        changed ();
+
         if (old_background_actor == null) {
             return;
         }
@@ -76,7 +76,6 @@ public class Gala.BackgroundManager : Meta.BackgroundGroup, Gala.BackgroundManag
             old_background_actor.destroy ();
         }
 
-        changed ();
     }
 
     private void update_background_actor (bool animate = true) {

Original file line number	Diff line number	Diff line change
`@@ -49,13 +49,13 @@ public class Gala.BackgroundManager : Meta.BackgroundGroup, Gala.BackgroundManag`
`49`	`49`	`}`
`50`	`50`	`}`
`51`	`51`
`52`		`- private void swap_background_actor (bool animate) {`
`53`		`- return_if_fail (new_background_actor != null);`
`54`		`-`
	`52`	`+ private void swap_background_actor (bool animate) requires (new_background_actor != null) {`
`55`	`53`	`var old_background_actor = background_actor;`
`56`	`54`	`background_actor = new_background_actor;`
`57`	`55`	`new_background_actor = null;`
`58`	`56`
	`57`	`+ changed ();`
	`58`	`+`
`59`	`59`	`if (old_background_actor == null) {`
`60`	`60`	`return;`
`61`	`61`	`}`
`@@ -76,7 +76,6 @@ public class Gala.BackgroundManager : Meta.BackgroundGroup, Gala.BackgroundManag`
`76`	`76`	`old_background_actor.destroy ();`
`77`	`77`	`}`
`78`	`78`
`79`		`- changed ();`
`80`	`79`	`}`
`81`	`80`
`82`	`81`	`private void update_background_actor (bool animate = true) {`