Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings portal doesn't work with automatic accent color #149

Open
alice-mkh opened this issue Jun 20, 2024 · 2 comments
Open

Settings portal doesn't work with automatic accent color #149

alice-mkh opened this issue Jun 20, 2024 · 2 comments

Comments

@alice-mkh
Copy link
Contributor

alice-mkh commented Jun 20, 2024

What Happened?

Basically if set to automatic we just return black color instead, which is not that great.

Steps to Reproduce

  1. Set accent to automatic
  2. Open any non-elementary app that supports fdo accent color (e.g. nightly gnome apps)

Expected Behavior

It should just follow the same color elementary apps use

OS Version

7.x (Horus)

Software Version

Compiled from git

Log Output

No response

Hardware Info

No response

@alice-mkh
Copy link
Contributor Author

There is relevant code for that in AccentColorManager, but the problem is that the portal is a separate binary atm. They can be merged, but it's messy.

A simpler (tho less robust) way is to have portal listen to gtk-theme instead and check the name. I can open a MR, but wanted to make sure it's fine here.

@danirabbit
Copy link
Member

@alice-mkh sorry for not following up sooner! I think that sounds like an acceptable way to get this working right away and we can reconsider as we revisit accent colors in OS 9. Thank you!

@danirabbit danirabbit added this to OS 9 Oct 23, 2024
@danirabbit danirabbit moved this to Todo in OS 9 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Confirmed
Development

No branches or pull requests

2 participants