Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BGRT image for manufacturer logo #278

Open
danirabbit opened this issue Dec 20, 2023 · 1 comment
Open

Use BGRT image for manufacturer logo #278

danirabbit opened this issue Dec 20, 2023 · 1 comment
Labels
Good First Issue Small, self-contained issue. Good for newcomers, and/or should be an easy fix. Status: Confirmed Verified by someone other than the reporter

Comments

@danirabbit
Copy link
Member

Problem

We have this custom OEM conf that nobody uses, but manufacturers do supply an image that is widely adopted at /sys/firmware/acpi/bgrt/image

Proposal

We should drop our custom manufacturer logo thing and use the widely adopted way manufacturers already set their logo

Prior Art (Optional)

Plymouth :)
@danirabbit danirabbit added the Needs Design Waiting for input from the UX team label Dec 20, 2023
@danirabbit danirabbit added this to OS 8 Dec 20, 2023
@danirabbit danirabbit moved this to Todo in OS 8 Dec 20, 2023
@danirabbit danirabbit added Good First Issue Small, self-contained issue. Good for newcomers, and/or should be an easy fix. and removed Needs Design Waiting for input from the UX team labels Dec 20, 2023
@danirabbit
Copy link
Member Author

Screenshot from 2023-12-20 14 26 19

It's easy enough to just grab the image but I wonder if we should try to do something here to remove the background or something

@lenemter lenemter added the Status: Confirmed Verified by someone other than the reporter label Jan 27, 2024
@lenemter lenemter added Needs Design Waiting for input from the UX team and removed Needs Design Waiting for input from the UX team labels Mar 27, 2024
@danirabbit danirabbit removed this from OS 8 Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Small, self-contained issue. Good for newcomers, and/or should be an easy fix. Status: Confirmed Verified by someone other than the reporter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danirabbit @lenemter