Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button dark in both default and dark modes #226

Open
D0J0P opened this issue Oct 12, 2021 · 2 comments
Open

Close button dark in both default and dark modes #226

D0J0P opened this issue Oct 12, 2021 · 2 comments

Comments

@D0J0P
Copy link

D0J0P commented Oct 12, 2021

What Happened?

This is probably something that always existed before we had dark mode, but the close button on notifications in the panel and popups is dark on both default and dark mode.

Steps to Reproduce

Screenshot from 2021-10-11 20-28-54
Screenshot from 2021-10-11 20-29-23

Expected Behavior

Maybe a light version for the default theme.

OS Version

6.x (Odin)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

@lenemter
Copy link
Member

I believe this is a conscious design decision. @danirabbit should this be closed?

@danirabbit
Copy link
Member

I think we are inverting the colors for overlay UI elements in other cases, like toasts. So this seems valid. We should probably rely on the osd class for setting the style here, but I’m not sure if that only exists in Gtk4 or if we support it in gtk3 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants