Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend battery names to be more fine-grained #257

Open
danirabbit opened this issue Feb 24, 2021 · 4 comments
Open

extend battery names to be more fine-grained #257

danirabbit opened this issue Feb 24, 2021 · 4 comments

Comments

@danirabbit
Copy link
Member

Problem

We have 16px of width in symbolic icons and 24px and 38px vertically in color icons to work with for battery levels, but we're currently only using 4 levels. We could be providing much more fine-grained battery levels if we wanted

Proposal

If we stretched the 48px battery icons a couple pixels, we'd have numbers divisible by 8 instead. We could be twice as accurate in showing battery levels

Prior Art

The freedesktop spec only includes battery-low (defined as 20%) and battery-caution (defined as 40%)—Which are apparently being used incorrectly right now. The other icon names we're currently using good, full, and empty are just convention from GNOME.

@NikoKrause
Copy link

Adwaita included als more fine-grained battery icons recently: https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/tree/master/Adwaita/scalable/status

@hanaral
Copy link

hanaral commented Mar 4, 2021

So are we doing this in tens?

@danirabbit
Copy link
Member Author

Gonna move this to the power indicator since it's the only place battery icons are used

@danirabbit danirabbit transferred this issue from elementary/icons Jun 6, 2024
@danirabbit
Copy link
Member Author

Symbolics are merged now. So we have a couple options for device icons in the menu. We can either:

  • make all the full color equivalent icons in 48px and 32px
  • Use the symbolic icons in the row instead of overlaying a color icon
  • Follow system settings and use a levelbar

I'm honestly inclined to either do the levelbar or the symbolic icon because it's so much less work. Maybe in GTK4 we can also do some fancy custom widgets to do a more compact design like:

re0b0te030ta1-524627820

--

MacOS example of using symbolic icon in the row:
Graphic-one-1

System Settings uses levelbars:
Screenshot from 2024-09-10 15 01 50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants