Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An empty footer adds an indent - Unnecessary CSS #177

Open
vovkasolovev opened this issue Sep 13, 2021 · 2 comments
Open

An empty footer adds an indent - Unnecessary CSS #177

vovkasolovev opened this issue Sep 13, 2021 · 2 comments

Comments

@vovkasolovev
Copy link

If the footer is empty, then its block is still displayed on the page adding an indent to the bottom, because the styles for the tag specified padding.

<footer id="site-footer" class="site-footer" role="contentinfo"></footer>

.site-footer {
padding-top: 1rem;
padding-bottom: 1rem;
}
@rami-elementor
Copy link
Member

We are aware of this issue.

You can fix that empty line by creating a custom footer using the Elementor Theme Builder.

@vovkasolovev
Copy link
Author

I reported a problem that happens when the footer is not needed and not used, (one of the reasons is page optimization). If you add a footer template with it you add unnecessary footer code, which can affect some other elements, styles or scripts. There is no need to look for workaround such as using extra templates, this style is just not needed in an empty theme.

I could suggest a simpler workaround: to override this CSS style, but I didn't, because I hope the developers will be able to implement the obvious solution - no unnecessary CSS and HTML markup if the element is absent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants