Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

parameterize retrying-on-value #60

Open
elennick opened this issue Feb 13, 2018 · 2 comments
Open

parameterize retrying-on-value #60

elennick opened this issue Feb 13, 2018 · 2 comments

Comments

@elennick
Copy link
Owner

https://github.com/elennick/retry4j/blob/master/src/main/java/com/evanlennick/retry4j/config/RetryConfig.java#L20

Retrying by value doesn't need to just use a vague Object like this... we know what the type is. Can use generics to more strongly type this to whatever the return value of the Callable is.

@elennick elennick self-assigned this May 28, 2018
@elennick elennick removed their assignment Jul 14, 2018
@dev3loperb
Copy link
Contributor

Can you share the status of this issue, please. I've seen that there was the PR #64, but it's closed.
I'd like to extend this to accept null values. Maybe it will be needed to add a new method aka retryOnNull, not sure yet.

@elennick
Copy link
Owner Author

@ipergenitsa I started investigating resolving it a while back but wasn't happy with the direction my solution was taking so I closed that PR. If you'd like to take another stab at it and submit a PR that would be totally fine... i can assign this to you for now to look into.

@elennick elennick added this to the 0.15.0 milestone Aug 12, 2018
@elennick elennick removed this from the 0.15.0 milestone Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants