Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift problem with vanilla PuTTY #2630

Open
unxed opened this issue Jan 12, 2025 · 2 comments
Open

Shift problem with vanilla PuTTY #2630

unxed opened this issue Jan 12, 2025 · 2 comments

Comments

@unxed
Copy link
Contributor

unxed commented Jan 12, 2025 •
edited
Loading

Finally vanilla PuTTY now can support keyboard mode used by far2l in tty mode, so most of keys should work even in unpatched version. The right settings are Xterm 216+ and xterm-style bitmap:

изображение

But Shift+Control+Arrows are still not working. I investigated escape codes that PuTTY sends in this mode. For Control+Shift+Right it sends ESC[1;6C — just the same that GNOME Terminal sends. But in far2l Shift press is still not seen.
@unxed unxed mentioned this issue Jan 12, 2025
Open
@unxed unxed changed the title Shift porblem with vanilla PuTTY Shift problem with vanilla PuTTY Jan 12, 2025
@unxed
Copy link
Contributor Author

unxed commented Jan 12, 2025 •
edited
Loading

Found a reason. It's ChangeKeypad(true); in TTYOutput::TTYOutput.

In PuTTY, enabling keypad mode makes it ignore Shift and Control modifiers.

Why at all do we need it enabled? Isn't it better to use classic, xterm mode?

At least maybe make it user configurable?

@unxed
Copy link
Contributor Author

unxed commented Jan 12, 2025

ChangeKeypad(true); was added on Oct 11, 2018 in
b6ed8c4

@elfmz do you remember why it is there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@unxed