Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical - Move linting tests to their own test suite #495

Open
Fancien opened this issue Nov 22, 2023 · 0 comments
Open

Technical - Move linting tests to their own test suite #495

Fancien opened this issue Nov 22, 2023 · 0 comments

Comments

@Fancien
Copy link
Collaborator

Fancien commented Nov 22, 2023

Is your feature request related to a problem? Please describe.

At the moment, the linting run in the same test suite as pytest, meaning that they need the docker image to be up and running.

Describe the solution requested

It would be more efficient to run the linting in a separate test suite. This would avoid building the docker image.

Describe possible alternatives

Another alternative would be to put the linting test before the image building step in the test suite, but a consequence of that is that the unittests would not run if black or flake8 report an issue.

Other info context

The impacted file would be the main.yml in the github workflows.

@Fancien Fancien changed the title Move linting tests to their own test suite Technical - Move linting tests to their own test suite Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant