Skip to content

Commit 47ec63b

Browse files
committed
fix: use mint passive mode
1 parent f80c97d commit 47ec63b

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

lib/tesla/adapter/mint.ex

+2
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,8 @@ if Code.ensure_loaded?(Mint.HTTP) do
155155
_ -> opts
156156
end
157157

158+
opts = Map.put_new(opts, :mode, :passive)
159+
158160
with {:ok, conn} <-
159161
HTTP.connect(String.to_atom(uri.scheme), uri.host, uri.port, Enum.into(opts, [])) do
160162
# If there were redirects, and passed `closed_conn: false`, we need to close opened connections to these intermediate hosts.

test/tesla/adapter/mint_test.exs

+4-4
Original file line numberDiff line numberDiff line change
@@ -80,14 +80,14 @@ defmodule Tesla.Adapter.MintTest do
8080
assert byte_size(response.body) == 16
8181
end
8282

83-
describe "mode: :passive" do
83+
describe "mode: :active" do
8484
test "body_as: :plain" do
8585
request = %Env{
8686
method: :get,
8787
url: "#{@http}/stream-bytes/10"
8888
}
8989

90-
assert {:ok, %Env{} = response} = call(request, mode: :passive)
90+
assert {:ok, %Env{} = response} = call(request, mode: :active)
9191
assert response.status == 200
9292
assert byte_size(response.body) == 16
9393
end
@@ -98,7 +98,7 @@ defmodule Tesla.Adapter.MintTest do
9898
url: "#{@http}/stream-bytes/10"
9999
}
100100

101-
assert {:ok, %Env{} = response} = call(request, body_as: :stream, mode: :passive)
101+
assert {:ok, %Env{} = response} = call(request, body_as: :stream, mode: :active)
102102
assert response.status == 200
103103
assert Enum.join(response.body) |> byte_size() == 16
104104
end
@@ -109,7 +109,7 @@ defmodule Tesla.Adapter.MintTest do
109109
url: "#{@http}/stream-bytes/10"
110110
}
111111

112-
assert {:ok, %Env{} = response} = call(request, body_as: :chunks, mode: :passive)
112+
assert {:ok, %Env{} = response} = call(request, body_as: :chunks, mode: :active)
113113
assert response.status == 200
114114
%{conn: conn, ref: ref, opts: opts, body: body} = response.body
115115

0 commit comments

Comments
 (0)