From bb78231e68168f4e248e8121fd1bb8012056d650 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sa=C3=BAl=20Cabrera?= Date: Sat, 9 Feb 2019 10:00:24 -0500 Subject: [PATCH] Update .travis.yaml to include the 3 latest elixir versions (#414) * Update .travis.yaml to include the 3 latest elixir versions * Avoid using `super` in GenServer callbacks Using `super` in GenServer callbacks was deprecated in elixir 1.7, to avoid compilation warnings, this commit replaces all calls to `super` with an explicit return --- .travis.yml | 6 +++--- lib/wallaby/driver/process_workspace/server.ex | 4 ++-- lib/wallaby/phantom/server.ex | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index 9dabbb1a..a0dfd57c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,8 +1,8 @@ language: elixir elixir: - - 1.4.5 - - 1.5.3 - - 1.6.4 + - 1.6.6 + - 1.7.4 + - 1.8.1 otp_release: - 20.3 env: diff --git a/lib/wallaby/driver/process_workspace/server.ex b/lib/wallaby/driver/process_workspace/server.ex index 199b26ca..a1a32290 100644 --- a/lib/wallaby/driver/process_workspace/server.ex +++ b/lib/wallaby/driver/process_workspace/server.ex @@ -22,11 +22,11 @@ defmodule Wallaby.Driver.ProcessWorkspace.Server do File.rm_rf(workspace_path) {:stop, :normal, state} end - def handle_info(msg, state), do: super(msg, state) + def handle_info(_, state), do: {:noreply, state} @impl GenServer def terminate(:shutdown, %{workspace_path: workspace_path}) do File.rm_rf(workspace_path) end - def terminate(reason, state), do: super(reason, state) + def terminate(_, _), do: :ok end diff --git a/lib/wallaby/phantom/server.ex b/lib/wallaby/phantom/server.ex index 616712cb..ab8c80b1 100644 --- a/lib/wallaby/phantom/server.ex +++ b/lib/wallaby/phantom/server.ex @@ -85,7 +85,7 @@ defmodule Wallaby.Phantom.Server do def handle_info({port, {:exit_status, status}}, %ServerState{wrapper_script_port: port} = state) do {:stop, {:exit_status, status}, state} end - def handle_info(msg, state), do: super(msg, state) + def handle_info(_, state), do: {:noreply, state} @impl GenServer def terminate(_reason, %ServerState{wrapper_script_port: wrapper_script_port, wrapper_script_os_pid: wrapper_script_os_pid}) do