Change port selection to random (#90)

* Change port selection to random

* Change get_valid_pair to use enums

Author: Qizot

lib/ex_ice/priv/checklist.ex

@@ -19,19 +19,17 @@ defmodule ExICE.Priv.Checklist do
     checklist
     # pair might have been marked as failed if the associated
     # local candidate has been closed
-    |> Stream.filter(fn {_id, pair} -> pair.state == :succeeded end)
-    |> Stream.filter(fn {_id, pair} -> pair.valid? end)
+    |> Enum.filter(fn {_id, pair} -> pair.state == :succeeded and pair.valid? end)
     |> Enum.max_by(fn {_id, pair} -> pair.priority end, fn -> {nil, nil} end)
     |> elem(1)
   end
 
   @spec get_valid_pair(t()) :: CandidatePair.t() | nil
   def get_valid_pair(checklist) do
     checklist
-    |> Stream.map(fn {_id, pair} -> pair end)
-    |> Stream.filter(fn pair -> pair.valid? end)
-    |> Enum.sort_by(fn pair -> pair.priority end, :desc)
-    |> Enum.at(0)
+    |> Enum.filter(fn {_id, pair} -> pair.valid? end)
+    |> Enum.max_by(fn {_id, pair} -> pair.priority end, fn -> {nil, nil} end)
+    |> elem(1)
   end
 
   @spec find_pair(t(), CandidatePair.t()) :: CandidatePair.t() | nil

lib/ex_ice/priv/gatherer.ex

@@ -63,7 +63,9 @@ defmodule ExICE.Priv.Gatherer do
       inet
     ]
 
-    Enum.reduce_while(gatherer.ports, nil, fn port, _ ->
+    gatherer.ports
+    |> Enum.shuffle()
+    |> Enum.reduce_while(nil, fn port, _ ->
       case gatherer.transport_module.open(port, socket_opts) do
         {:ok, socket} ->
           {:ok, {^ip, sock_port}} = gatherer.transport_module.sockname(socket)