Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot_quality() works reasonably well for single sources but fails for larger set #75

Closed
mdingemanse opened this issue Aug 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@mdingemanse
Copy link
Contributor

mdingemanse commented Aug 20, 2024

Running plot_quality() for eyeballing turn durations and transitions works as expected for single sources:

Reprex:

devtools::install_github("elpaco-escience/ifadv")
data <- init(ifadv::ifadv)

plot_quality(data, source = "/dutch2/DVA9M")

image

But for a full dataset consisting of multiple source it doesn't produce sensible results:

plot_quality(data)

image

I think what we get here is that transition times are computed across sources, resulting in some extremely long (nonextant) transitions.

Another reason I would much rather work with proper FTO calculations as proposed in #70.

@mdingemanse mdingemanse added the bug Something isn't working label Aug 20, 2024
@mdingemanse
Copy link
Contributor Author

To be fixed in branch 75-fix-qual-plots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant