fn type bound in Server.register might be slightly off

[SamWilsn]

The type bound for fn in register has a void return type:

rpc-websockets/src/lib/server.ts

Line 147 in 46b0190

register(name: string, fn: (params: IRPCMethodParams, socket_id: string) => void, ns = "/")

I'm rather new to TypeScript, but I would suggest a return type of unknown | Promise<unknown> to hint that the function is await'd later on:

rpc-websockets/src/lib/server.ts

Lines 697 to 698 in 46b0190

	response = await this.namespaces[ns].rpc_methods[message.method]
	.fn(message.params, socket_id)

[mkozjak]

Hi, @SamWilsn, are there any issues you came across in production that's touching on this code?

[SamWilsn]

are there any issues you came across in production that's touching on this code?

Here's an example:

https://github.com/wallet-test-framework/glue-ws/blob/0322225d8979f2d3995efb1d703d98c6f672f75d/src/index.ts#L68-L70

I have to disable the @typescript-eslint/no-misused-promises lint because the function doesn't declare that it may return a Promise.