Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Use Microsoft.IO.RecyclableMemoryStream #6087

Open
adamradocz opened this issue Oct 31, 2024 · 1 comment · May be fixed by #6093
Open

[CHORE] Use Microsoft.IO.RecyclableMemoryStream #6087

adamradocz opened this issue Oct 31, 2024 · 1 comment · May be fixed by #6093
Labels
maintenance This issue is about maintenance of the code base and related aspects
Milestone
Elsa 3.4

Comments

@adamradocz
Copy link

Maintenance Task Request

Task Overview

What maintenance task do you propose? Please describe.
In the code new MemoryStream()s are created 7 times. This could be optimized with pooling by using the Microsoft.IO.RecyclableMemoryStream nuget.

Purpose of the Task

Explain why this task is necessary
Improved performance.

Potential Issues

Identify any potential issues that might arise from this task
Can't think of any.

Additional Context

Add any other context
Repo: RecyclableMemoryStream
@adamradocz adamradocz added the maintenance This issue is about maintenance of the code base and related aspects label Oct 31, 2024
@sfmskywalker sfmskywalker added this to the Elsa 3.3 milestone Nov 1, 2024
@sfmskywalker sfmskywalker moved this to Todo in ELSA 3 Nov 1, 2024
@sfmskywalker
Copy link
Member

That's an excellent idea, thanks for proposing it @adamradocz !

@adamradocz adamradocz linked a pull request Nov 2, 2024 that will close this issue
Open
@sfmskywalker sfmskywalker modified the milestones: Elsa 3.3, Elsa 3.4 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance This issue is about maintenance of the code base and related aspects
Projects
ELSA 3
Status: Todo
Milestone
Elsa 3.4
Development

Successfully merging a pull request may close this issue.

Switch MemoryStream to Microsoft.IO.RecyclableMemoryStream. adamradocz/elsa-core
2 participants
@sfmskywalker @adamradocz