[BUG] Memory increasing with ActivityOutputRecord

[iio888]

Description

Program memory will increase continuously when execute a activity with result in a loop.

Steps to Reproduce

Here is my workflow to run.

internal class EndlessWorkflow : WorkflowBase
{
    protected override void Build(IWorkflowBuilder builder)
    {
        builder.Root = While.True(new If(c => true) 
        {
            Then = new Inline(c => Console.WriteLine(“loop”)
        };
    }
} 

Actual Behavior

The number of _records in ActivityOutputRegister is increasing continuously. The memory is going to be 700M after 15 min.

Environment

• Elsa Package Version: 3.2.3

[iio888]

I noticed that there is a similar issue #4900 which has been closed. But I think the core problem has not been resolved. The real reason causes this issues is that the activity (If in my example) is setting result continuously (calling context.Set method) and the ActivityOutputRecord is created continuously at the same time.
In my example code, my workflow won’t exit. So ActivityOutputRegister won’t be disposed, too.

[sfmskywalker]

I think that makes sense, because for each activity execution, any of its output is captured. So the question is, what kind of controls should we offer to manage this? For example:

• Provide a threshold configuration that will discard older output.
• Disable collecting output altogether
• Flush output to the underlying store during commit states (which is part of a separate issue).

Thoughts?