Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ComputeBookmarkHash in HttpWorkflowsMiddleware #6161

Open
mehmet-hoke opened this issue Nov 28, 2024 · 0 comments
Open

[BUG] ComputeBookmarkHash in HttpWorkflowsMiddleware #6161

mehmet-hoke opened this issue Nov 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mehmet-hoke
Copy link

In HttpWorkflowsMiddleware class, ComputeBookmarkHash method

private string ComputeBookmarkHash(IServiceProvider serviceProvider, string path, string method)
{
var bookmarkPayload = new HttpEndpointBookmarkPayload(path, method);
var bookmarkHasher = serviceProvider.GetRequiredService();
var activityTypeName = ActivityTypeNameHelper.GenerateTypeName();
return bookmarkHasher.Hash(activityTypeName, bookmarkPayload);
}

ActivityTypeNameHelper.GenerateTypeName();

in this line it uses HttpEndpoint as a constant. But it records to the Bookmarks table with its customized name (in my case Elsa.HRVHTTPEndpoint) and creates the hash value in this way.
Therefore, it cannot find the record with the Hash value created with HttpEndpoint and the worklow does not continue.

Different type names work when creating(HRVHTTPEndpoint) a bookmark and consuming(HTTPEndpoint)

@mehmet-hoke mehmet-hoke added the bug Something isn't working label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant