3.3.0-rc-3 => Elsa.Retention.Options: Missing SweepInterval

[r-kernberger]

In the class Elsa.Retention.Options.CleanupOptions of package Retention, there is missing an important setting, which has been available in prior versions of the retention module

=> SweepInterval

With this settting it has been possible to define how often the Retention Job is running (every x days, hours, minutes).

Now with this settings missing, there is the default value of every 4 hours. Which is especially for development / testing not good.

Will this setting be available in v3.3? Has this been removed on purpose?

[jayachandra21]

Hello @r-kernberger, I have observed the same at the Elsa 3.3.0 RC3.
Also I have configured the Retention module with following and I have observed that instances are not deleted.
Even if, Sweep Interval is 4 hours, I could still see the instances are which older then the 4 hours.

elsa.UseRetention(retention =>
  {
      retention.ConfigureCleanupOptions = options =>
      {
          //options.SweepInterval = TimeSpan.FromHours(4);
          options.PageSize = 25;
      };
  });

[r-kernberger]

Did you define a delete policy like this:

retention.AddDeletePolicy("Delete Workflow Instances", _ => new DeleteFilter());

The DeleteFilter could look like this

public class DeleteFilter : RetentionWorkflowInstanceFilter
{
    //Finished Workflows
    public DeleteFilter()
    {
        WorkflowStatus = Elsa.Workflows.WorkflowStatus.Finished;
    }
}

Update:
I double checked it. My Instances have not been deleted despite defining a delete policy like above. Not even after 4 hours waiting.

[jayachandra21]

Did you define a delete policy like this:

retention.AddDeletePolicy("Delete Workflow Instances", _ => new DeleteFilter());

The DeleteFilter could look like this

public class DeleteFilter : RetentionWorkflowInstanceFilter
{
    //Finished Workflows
    public DeleteFilter()
    {
        WorkflowStatus = Elsa.Workflows.WorkflowStatus.Finished;
    }
}

Update: I double checked it. My Instances have not been deleted despite defining a delete policy like above. Not even after 4 hours waiting.

Yes, it is the same from myside too. The following i have configured.
elsa.UseRetention(retention =>
{
retention.ConfigureCleanupOptions = options =>
{
options.PageSize = 25;
};

 retention.AddDeletePolicy("Delete completed workflows", sp =>
 {
     RetentionWorkflowInstanceFilter filter = new()
     {
         WorkflowStatus = WorkflowStatus.Finished
     };
     return filter;
 });

});

[Sverre-W]

I've made a PR: #6208 to add the SweepInterval. Not sure why it's not deleting, I will try to replicate and fix it over the weekend.

[Sverre-W]

I've tested with a simple writeline workflow but seems to work as expected.

My setup:

  elsa.UseRetention(r =>
            {
                r.SweepInterval = TimeSpan.FromSeconds(30);
                r.AddDeletePolicy("Delete all finished workflows", _ => new RetentionWorkflowInstanceFilter()
                {
                    WorkflowStatus = WorkflowStatus.Finished
                });
            });

Output:

info: Elsa.Retention.Jobs.CleanupJob[0]
      Cleaned up 1 workflow instances through Delete all finished workflows
Hello world
Hello world
Hello world
info: Elsa.Retention.Jobs.CleanupJob[0]
      Cleaned up 3 workflow instances through Delete all finished workflows

Note: I did notice the minum sweep interval is 1 minute, settings 30 seconds will still result in one sweep per minute.

[sfmskywalker]

Done via #6211
Thanks @Sverre-W !

[jayachandra21]

Hello @Sverre-W ,

Thank you very much!
I have configured the retention module with Elsa 3.0 RC4 as below.

elsa.UseRetention(r =>
            {
                r.SweepInterval = TimeSpan.FromMinutes(10);
                r.AddDeletePolicy("Delete all finished workflows", _ => new RetentionWorkflowInstanceFilter()
                {
                    WorkflowStatus = WorkflowStatus.Finished
                });
            });

I think the Sweep Interval is considering the minute to delete the finished instances but not considered the configured as above.

Step1: Local time is 6:20 - I have 9 instances with finished state

Step2 : At 6:24 - Deleted the all above instances.

Is it something missing in the configuration to work as expected?

[jayachandra21]

@Sverre-W @r-kernberger did you tried the scenario which I have highlighted at your side? because to ensure that Retention options is working as expected.