Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Log Persistence Mode Expression Timing #6216

Open
sfmskywalker opened this issue Dec 16, 2024 · 0 comments
Open

[BUG] Log Persistence Mode Expression Timing #6216

sfmskywalker opened this issue Dec 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@sfmskywalker
Copy link
Member

sfmskywalker commented Dec 16, 2024

Log Persistence Mode expressions are evaluated at commit state instead of immediately after activity execution. This leads to issues where:

  • Expressions rely on the latest variable value rather than the value during activity execution.
  • Activity contexts and execution records are mismatched at evaluation.

Problem

Workflows using dynamic variables face incorrect log persistence decisions because:

  • Expressions use the wrong variable value.
  • Activity logs do not match their execution context.

Steps to Reproduce

  1. Create a workflow with activities and a Log Persistence Mode expression using a workflow variable.
  2. Update the variable between activity executions.
  3. Observe that expressions evaluate the variable’s latest value, not the value during execution.

log-persistence-issue.json

image

Expected Behavior

Expressions should evaluate immediately after activity execution to reflect the correct variable state.

Suggested Fix

Update the workflow runner to evaluate Log Persistence Mode expressions after each activity executes instead of at commit state.

@sfmskywalker sfmskywalker added the bug Something isn't working label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant