Skip to content

Commit 36d68e8

Browse files
gumpteaufavor
authored andcommitted
expose getters for cache and hit spans
1 parent fa4654a commit 36d68e8

File tree

3 files changed

+21
-3
lines changed

3 files changed

+21
-3
lines changed

.bleep

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
624b1bc2959636de01cbb6f9da86df12784fa812
1+
fc39bb0c3d35fa5e07c21c261c2a5a68af53d440

pingora-cache/src/lib.rs

+12-2
Original file line numberDiff line numberDiff line change
@@ -457,9 +457,19 @@ impl HttpCache {
457457
}
458458
}
459459

460+
// Get the cache parent tracing span
461+
pub fn get_cache_span(&self) -> Option<trace::SpanHandle> {
462+
self.inner.as_ref().map(|i| i.traces.get_cache_span())
463+
}
464+
460465
// Get the cache `miss` tracing span
461-
pub fn get_miss_span(&mut self) -> Option<trace::SpanHandle> {
462-
self.inner.as_mut().map(|i| i.traces.get_miss_span())
466+
pub fn get_miss_span(&self) -> Option<trace::SpanHandle> {
467+
self.inner.as_ref().map(|i| i.traces.get_miss_span())
468+
}
469+
470+
// Get the cache `hit` tracing span
471+
pub fn get_hit_span(&self) -> Option<trace::SpanHandle> {
472+
self.inner.as_ref().map(|i| i.traces.get_hit_span())
463473
}
464474

465475
// shortcut to access inner, panic if phase is disabled

pingora-cache/src/trace.rs

+8
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,10 @@ impl CacheTraceCTX {
4646
self.cache_span = cache_span;
4747
}
4848

49+
pub fn get_cache_span(&self) -> SpanHandle {
50+
self.cache_span.handle()
51+
}
52+
4953
#[inline]
5054
pub fn child(&self, name: &'static str) -> Span {
5155
self.cache_span.child(name, |o| o.start())
@@ -70,6 +74,10 @@ impl CacheTraceCTX {
7074
.set_tag(|| Tag::new("status", hit_status.as_str()));
7175
}
7276

77+
pub fn get_hit_span(&self) -> SpanHandle {
78+
self.hit_span.handle()
79+
}
80+
7381
pub fn finish_hit_span(&mut self) {
7482
self.hit_span.set_finish_time(SystemTime::now);
7583
}

0 commit comments

Comments
 (0)