Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question][1.16.5] Heat Sources #114

Open
drakray opened this issue Sep 27, 2021 · 2 comments
Open

[Question][1.16.5] Heat Sources #114

drakray opened this issue Sep 27, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@drakray
Copy link

drakray commented Sep 27, 2021

I see in the code these as Heat Source:
MAGMA_BLOCK
FIRE
SOUL_FIRE
LAVA
CAMPFIRE.LIT
SOUL_CAMPFIRE.LIT

Is there a way to configure more source?
Either by Config or blockTags?
I'd like some modded source to count, like SoulFire from Druidcraft, SpiritFire from Occultism, Campfires from OhTheBiomesYoullGo and EndergeticExpansion, and FirePlace from Vampirism

Something like blockTag:forge:heat_source would make that easily configurable with CraftTweaker, for example, and make modder able to implement it by default if they want

@Alexthw46
Copy link

About campfires, the solution can be easily achived replacing the vanilla check with a generic (instance of CampfireBlock && [isLit] ).

I added that line in Hexblades update, but having a tag here in Eidolon would be easier and more compatible.

@drakray
Copy link
Author

drakray commented Sep 28, 2021

Yeah, I think Elucent should make the Crucible use blockTags, something like forge:heat_source, it would make it MUCH easier to adapt in mods and modPack using CraftTweaker

EDIT: I just realized we are ALREADY on Eidolon's issue tracker, not Hexblades lol XD
Crossed wires XD

@elucent elucent added the enhancement New feature or request label Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants