Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'UK' is in country mentions #15

Open
VanessaVanG opened this issue Aug 13, 2018 · 2 comments
Open

'UK' is in country mentions #15

VanessaVanG opened this issue Aug 13, 2018 · 2 comments

Comments

@VanessaVanG
Copy link

"The official ISO country code for the United Kingdom is 'GB'. The code 'UK' is reserved."
Both UK and GB are returned in my country mentions for some reason. I'm not even sure what the UK ones are from. (I'm using this on a huge file so there's no way to tell what places it's deeming as UK)

@hernandezrivera
Copy link

hernandezrivera commented Sep 12, 2018

I had the same issue. Getting 'GB' for United Kingdom and when trying to get the country name with pycountry, it doesn't recognize it, so I have to do the change manually to 'GB' case by case.
It would be good to have United Kingdom returning 'GB' instead of 'GB'.
List of iso2 codes

Seeing the txt with the list of countries, it seems that it is using the fips code instead of the iso2.
Also, there are some other countries that have a different fips than iso2 (fips vs iso list=, so this issue impacts other countries too.

I don't understand how it happens as it seems geotext.py is grabbing the proper columns of the file:

    countries = read_table(
        get_data_path('countryInfo.txt'), usecols=[4, 0], skip=1)

@albertc1
Copy link
Contributor

albertc1 commented Feb 2, 2019

I ran into this problem too, as well as a few others. Looks like it was coming from nationalities.txt: #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants