Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case insensitive option #19

Open
NicolleLouis opened this issue Jan 25, 2019 · 2 comments
Open

Case insensitive option #19

NicolleLouis opened this issue Jan 25, 2019 · 2 comments

Comments

@NicolleLouis
Copy link

NicolleLouis commented Jan 25, 2019

Hi,

First of all thanks for your work, it works well and it's really useful.

What do you think of an option to make a case insensitive search for city/country names. I'm trying to do it for my project, I can send you a PR if you want and I succeed.

@albertc1
Copy link
Contributor

I have a fork that includes case insensitive support and a few other features (support for states/provinces/etc., more languages parsed), but is probably a bit slower and might get you more false positives:
https://github.com/tubular/geotext . If you try it and it works well for you, let me know and I can make a PR back to this main project

@NicolleLouis
Copy link
Author

Hi, thanks for your answer.

I'm sorry albertc1, I made a custom solution before seeing your message, so I didn't try your fork. Thus I can't tell you if it worked well for me.

Good luck for everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants