Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2264 Common Properties Button is hidden on height change #2265

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

#2264 Common Properties Button is hidden on height change #2265

wants to merge 3 commits into from

Conversation

srikant-ch5
Copy link
Contributor

Fixes: #2264

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@srikant-ch5 srikant-ch5 self-assigned this Dec 10, 2024
@matthoward366
Copy link
Member

@srikant-ch5 can you fix the build?

@srikant-ch5
Copy link
Contributor Author

@srikant-ch5 can you fix the build?

Build is failing because tests are failing due to below error.

Screenshot 2024-12-10 at 7 24 50 PM

I think its not related to the changes in this PR as these are failing even when I test in main branch so trying to figure out the root cause.

@srikant-ch5
Copy link
Contributor Author

@matthoward366 Could you please have a look at this PR ?

matthoward366
matthoward366 reviewed Dec 18, 2024
View reviewed changes
canvas_modules/common-canvas/src/common-properties/properties-main/properties-main.jsx
// only hide resize button if resize wasn't from clicking resize button
if (!this.resizeClicked) {
this.setState({ showResizeBtn: false });
detectResize(_width, height) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you have _width and not just width to match height?

Copy link
Contributor Author

@srikant-ch5 srikant-ch5 Dec 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since width is not used anywhere in the function build was failing due to unused variable error so to overcome it I included _.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthoward366 matthoward366 matthoward366 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@srikant-ch5 srikant-ch5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Common Properties Button is hidden on height change
2 participants
@srikant-ch5 @matthoward366