Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper documentation #1

Open
appetrosyan opened this issue Apr 27, 2020 · 12 comments
Open

Proper documentation #1

appetrosyan opened this issue Apr 27, 2020 · 12 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@appetrosyan
Copy link

As of now the package's dependencies are completely unknown. Although it can be installed, I don't know how to start it. The official readme should include installation instructions.

@jcs090218
Copy link
Member

Hi, thanks for opening this issue!

Do you installed it from melpa? If you did, you can check the package page here. Then you will see the dependencies listed on that page!

@jcs090218 jcs090218 added documentation Improvements or additions to documentation good first issue Good for newcomers labels Apr 27, 2020
@appetrosyan
Copy link
Author

yes, from Melpa, and I did see "Grammarly support for Flycheck." as the documentation. As a package that potentially requires much configuration, it really needs more documentation. I'm happy to provide some if you would accept a PR.

@jcs090218
Copy link
Member

I would accept a PR if it helps the community! :D Feel free to open it!

@mmagnus
Copy link

mmagnus commented May 20, 2020

Yeah, please write more on how to use it. It look exciting!

@jcs090218
Copy link
Member

Thanks for being interested! I am not quite sure about the documentation you guys want. I think is pretty straight forward? 😕 You can enabled flycheck then it should work! If it doesn't, then is a bug. 😅

@mmagnus
Copy link

mmagnus commented May 21, 2020

OK ;-) yeah, I did that and I didn't work.. I wanted then to change flycheck checkers etc.. but nothing worked, ok, I try again ;)

@mmagnus
Copy link

mmagnus commented May 21, 2020

Screen Shot 2020-05-21 at 10 13 02 AM

OK, this was required to get this running for my MD files:

(require 'grammarly)
(require 'flycheck-grammarly)
(add-hook 'markdown-mode-hook 'flyspell-grammarly)

@appetrosyan I hope this helps.

@jcs090218 you could give a simple screenshot, you can take mine if you want, and just include this simple setup in the readme. It would help to get quickly what's going on. Now for me this seems obvious...

I developed myself some hacky way to use Grammarly, but it's nothing compared to the native support for Emacs.

@jcs090218
Copy link
Member

@mmagnus Interesting..., base on this line https://github.com/jcs-elpa/flycheck-grammarly/blob/72425743364f4fd9516f94546a7432457e1e7df0/flycheck-grammarly.el#L200

Should already have grammarly support in markdown-mode. I guess you would just need to call (require 'flycheck-grammarly) then it should work! Because this package already (require 'grammarly) and once loaded the line above will be called so the markdown-mode, text-mode, etc, will all have flycheck-grammarly support!

@ghost
Copy link

ghost commented Jun 27, 2020

I still can't understand where to enter login and password.

@jcs090218
Copy link
Member

@lockywolf Hi, here probably not the right place to discuss. You may discuss over here emacs-grammarly/grammarly#1. Hope this helps! :)

@jcs090218
Copy link
Member

Just to update this thread, I have added the basic usage in README file. Hope this helps!

@appetrosyan
Copy link
Author

Much better. As this is a kelps package, I would also add a version with use-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants