Don't include transient's menu window in saved window configuration #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jonas Bernoulli ***@***.***> writes:
Discussed at magit/transient#361.
Let's wait for @daedsidog to give it a try before you merge.
Ok, will see tomorrow, thanks.
… ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
You can view, comment on, or merge this pull request online at:
#2711
Commit Summary
• e451b6b Don't include transient's menu window in saved window configuration
File Changes
(1 file)
• M helm-core.el (15)
Patch Links:
• https://github.com/emacs-helm/helm/pull/2711.patch
• https://github.com/emacs-helm/helm/pull/2711.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.*Message ID: ***@***.***>
--
Thierry
|
|
@tarsius @thierryvolpiatto My Helm versions seems to be broken up into multiple packages ( I am happy to report that the bug I had is now absent. |
|
daedsidog ***@***.***> writes:
@tarsius @thierryvolpiatto My Helm versions seems to be broken up into multiple packages (helm-core + helm itself), so I applied the diff manually on helm-core.el for my version after
updating to the latest Transient.
I am happy to report that the bug I had is now absent.
Great, thanks to confirm. @tarsius let me know if I can merge.
…--
Thierry
|
|
We're good to go! |
|
Ok, merged! Thanks. |
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed at magit/transient#361.
Let's wait for @daedsidog to give it a try before you merge.