-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggressive-indent-mode incompatibility #30
Comments
If you use this (add-to-list
'aggressive-indent-dont-indent-if
'(and (derived-mode-p 'c++-mode)
(null (string-match "\\([;{}]\\|\\b\\(if\\|for\\|while\\)\\b\\)"
(thing-at-point 'line))))) Does it still happen? |
The problem isn't there anymore but aggressive-indent-mode doesn't do anything either. Even if my buffer doesn't match the regex (which is hard to create because it looks like it will match anything that has parens, ifs, etc). |
It works fine for me. Are you sure that the problem is not something else? |
I just tried my minimal config above together with your suggestion and the problem is still there (text is still deleted). I think I forgot to enable aggresive-indent in my last reply. I used this c++ sample file #include <stdio.h>
int main()
{
int i, j, rows;
printf("Enter number of rows: ");
scanf("%d",&rows);
for(i=1; i<=rows; ++i)
{
for(j=1; j<=i; ++j)
{
printf("* ");
}
printf("\n");
}
return 0;
} |
What emacs version are you running ?Also can you check if company is activated before or after aggressive-indent ? |
I'm running the latest stable arch linux build of emacs: (straight-use-package 'company)
(global-company-mode) to it with the same results as my last post |
Instead of (global-aggressive-indent-mode) can you try hooking up aggressive-indent-mode on c-mode-hook and c++-mode-hook? |
That seems to make it more stable, but text is still randomly deleted if you press delete in this situation
| = cursor |
OK at least we improved something, another concern i have is that Maskray has configured ccls in wiki using 3 different hooks from you. :hook ((c-mode c++-mode objc-mode) .
(lambda () (require 'ccls) (lsp))) Can you remove from your config (add-hook 'c-mode-hook 'lsp)
(add-hook 'c++-mode-hook 'lsp)
(add-hook 'objc-mode-hook 'lsp) and replace it with the equivalent code of straight.el-use-package based on the code i mentioned above? |
That's the same as (add-hook 'c-mode-hook '(lambda () (require 'ccls) (lsp)))
(add-hook 'c++-mode-hook '(lambda () (require 'ccls) (lsp)))
(add-hook 'objc-mode-hook '(lambda () (require 'ccls) (lsp))) which has the same problem |
I am not sure but c-mode and c-mode-hook are not the same. (add-hook 'c-mode '(lambda () (require 'ccls) (lsp)))
(add-hook 'c++-mode '(lambda () (require 'ccls) (lsp)))
(add-hook 'objc-mode '(lambda () (require 'ccls) (lsp))) |
No, every mode has a hook that is run when it is enabled, so what |
(setq lsp-enable-indentation nil) |
I can confirm the solution proposed from @0x00539 works. |
See emacs-lsp/emacs-ccls#30. 1. Disable lsp-enable-indent. 2. Disable lsp-enable-on-type-formatting.
Close #161. See emacs-lsp/emacs-ccls#30. 1. Disable lsp-enable-indent. 2. Disable lsp-enable-on-type-formatting.
When typing a bit after enabling both
aggressive-indent-mode
andemacs-ccls
, the text above and below where you are typing will get deleted. The problem is present with this minimal configThe text was updated successfully, but these errors were encountered: