Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for haskell-ts-mode #188

Open
ScamChamp opened this issue Sep 5, 2024 · 7 comments
Open

Support for haskell-ts-mode #188

ScamChamp opened this issue Sep 5, 2024 · 7 comments

Comments

@ScamChamp
Copy link

I had quick skim through code, and it seems like no feature from haskell mode is strictly required by lsp haskell that would be a big effort to change.
https://codeberg.org/pranshu/haskell-ts-mode

@michaelpj
Copy link
Collaborator

Sure, I'd take a PR for this.

@magthe
Copy link

magthe commented Sep 7, 2024

This would also address #181 .

@ScamChamp
Copy link
Author

I did manage to find this: magthe@2084ff1 . Can you see any problems with it?

@magthe
Copy link

magthe commented Sep 8, 2024

Well, it does replace all mentions of haskell-mode with haskell-ng-mode (my own attempt at a new mode for Haskell), so I'm guessing it won't work well with anything else.

I have since adjusted my change so that it

  1. removes the the requirement on haskell-mode, and
  2. adds mentions of haskell-ng-mode.

You can find it here. So far I've seen no problems with it.

I made a small addition on top of that, adding mentions of haskell-ts-mode as well, so you can more easily see if it'll work for you as well, @ScamChamp . magthe@e9d0f8a

@ScamChamp
Copy link
Author

Thanks magthe, I adapted the code to make it work for haskell-ts-mode. I personally don't use lsp-haskell, but lack of lsp support is an issue for some people.

@michaelpj This patch adds support for haskell-ts-mode

@magthe
Copy link

magthe commented Sep 14, 2024

Maybe it 's worth clarifying that I removed the requirement on haskell-mode, but left all the settings with it (putthing its modes in the various lists). I believe that'll keep lsp-haskell working with haskell-mode, but that needs verifying.

Then adding support for other Haskell modes is just a matter of adding them to the various list.

@michaelpj
Copy link
Collaborator

If someone can put up a PR and verify that it works with all three modes then I'm happy to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants