Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't abuse `ivy-configure' + display-transformer #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nbfalcon
Copy link
Member

@nbfalcon nbfalcon commented Nov 4, 2020

Fixes #18.

@sebastiansturm
Copy link
Contributor

thanks alot, much cleaner than the kludge I'd been using! And judging by ivy's documentation, I'd expect this to work since ivy apparently supports alist candidates. On the other hand, when I tried it out I ran into type errors complaining about the symbol information being a hash table instead of a list; as far as I could see so far, every candidate (textual-representation . symbol-information) is passed wholesale to ivy--add-face instead of just textual-representation.
Tomorrow I'll rebuild all my packages from scratch and try again just to make sure (or read through the relevant parts of ivy but I think I won't get to that before the weekend), but could you please tell me what ivy version you tested this with? And did you use lsp-mode's new plist representation?

@nbfalcon
Copy link
Member Author

nbfalcon commented Nov 4, 2020

;; Version: 0.13.0
  1. I haven't enabled `lsp-use-plists'.

I think I had some of these errors too, so you might want to wait before merging.

@nbfalcon
Copy link
Member Author

nbfalcon commented Nov 8, 2020

Ivy-update-candidates doesn't take alists. I've made an upstream PR to fix that.

@sebastiansturm
Copy link
Contributor

this is still waiting for abo-abo/swiper#2716, or did I miss something?

@nbfalcon
Copy link
Member Author

@sebastiansturm it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on running lsp-ivy-workspace-symbol
2 participants