Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node version requirements to documentation #58

Closed
Dadams2 opened this issue Jul 14, 2021 · 0 comments
Closed

Add node version requirements to documentation #58

Dadams2 opened this issue Jul 14, 2021 · 0 comments

Comments

@Dadams2
Copy link

Dadams2 commented Jul 14, 2021

I was attempting to install lsp-pyright on a centos7 machine without root privileges. For me the default versions were:

  • node v6.16.0
  • npm v3.10.10

When attempting to build pyright in doom emacs I kept getting
Syntax Error: Unexpected Token *

Updating the node version to 14 fixed this as I looked #35 which mentioned downgrading to node 14 was required on mac.

I am quite new to contributing so my question is would you be open to adding a quick section in the readme about node requirements as they are not obvious on microsofts documentation either?

I would be happy to investigate what versions work and don't.

@Dadams2 Dadams2 closed this as completed Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant