Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RP2: EndpointIn::write doesn't check enabled status #3426

Open
jamesmunns opened this issue Oct 18, 2024 · 0 comments · May be fixed by #3629
Open

RP2: EndpointIn::write doesn't check enabled status #3426

jamesmunns opened this issue Oct 18, 2024 · 0 comments · May be fixed by #3629

Comments

@jamesmunns
Copy link
Contributor

embassy/embassy-rp/src/usb.rs

Lines 605 to 643 in a580437

async fn write(&mut self, buf: &[u8]) -> Result<(), EndpointError> {
if buf.len() > self.info.max_packet_size as usize {
return Err(EndpointError::BufferOverflow);
}
trace!("WRITE WAITING");
let index = self.info.addr.index();
let val = poll_fn(|cx| {
EP_IN_WAKERS[index].register(cx.waker());
let val = T::dpram().ep_in_buffer_control(index).read();
if val.available(0) {
Poll::Pending
} else {
Poll::Ready(val)
}
})
.await;
self.buf.write(buf);
let pid = !val.pid(0);
T::dpram().ep_in_buffer_control(index).write(|w| {
w.set_pid(0, pid);
w.set_length(0, buf.len() as _);
w.set_full(0, true);
});
cortex_m::asm::delay(12);
T::dpram().ep_in_buffer_control(index).write(|w| {
w.set_pid(0, pid);
w.set_length(0, buf.len() as _);
w.set_full(0, true);
w.set_available(0, true);
});
trace!("WRITE OK");
Ok(())
}

I'm pretty sure the EpIn code doesn't check the endpoint status, so if you try to write while USB is disconnected, it'll just hang/sleep forever.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rp/usb: return error on disconnect birktj/embassy
1 participant
@jamesmunns