Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apache-nimble example #30

Merged
merged 9 commits into from
May 20, 2024
Merged

Conversation

Univa
Copy link
Contributor

@Univa Univa commented May 9, 2024

Hello!

I've been working on a fork of the apache-nimble-sys crate (PR here), where I have added bindings for NimBLE's controller, with bt-hci trait implementations. I was able to use trouble with it to create a basic GATT server with a battery level service, and I figured I would share it here. Note: wanted to leave this as draft for now to wait for input from the original repo's owner.

@lulf
Copy link
Member

lulf commented May 9, 2024

Thats really cool, thanks!

Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, just a minor nit. Just ping here again once you think it's ready.

examples/apache-nimble/memory.x Outdated Show resolved Hide resolved
@Univa Univa marked this pull request as ready for review May 17, 2024 23:20
@Univa
Copy link
Contributor Author

Univa commented May 18, 2024

@lulf This is ready to re-review and merge now :)

Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

/test

@lulf
Copy link
Member

lulf commented May 20, 2024

/test

@lulf lulf merged commit e291e2e into embassy-rs:main May 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants