Availability matrix doesn't update if there are no rooms available

[bfirsh]

Steps to reproduce:

• https://embassynetwork.com/locations/embassysf/stay/
• Select some dates where no rooms are available
• Switch to availability matrix
• Update dates to another date where no rooms are available
• Availability matrix doesn't update

There is error in console.

[est271]

I found the source of this bug but making modifications to correct/avoid it will change the behavior of the “Room Api List” page that uses the Django REST framework.

It appears from the RoomApiList.filter_queryset() method inside the module “modernomad/core/views/booking.py” that it is implemented to send a rooms information to the Api page only if the room is fully available within the arrive and depart dates in the Daterangeselector.

In RoomIndexOrDetail.jsx the fetchRooms method assigns to this.state.rooms the information that is in the Room Api page. If there is at least 1 room available during those dates then the AvailabilityMatrix.jsx renders the information for that 1 room. But if none of the rooms are available then this.state.rooms is set to an empty list which then sets this.props.rooms to an empty list. What happens next is that line 38 of the AvailabilityMatrix.jsx file will attempt to index that empty list.

const dateColumn = this.props.rooms[0].availabilities.map((availability) => {

This results in the error into the console and no longer displays the availability matrix correctly until the page is reloaded.

est271/modernomad/pull/2/files

Edit:
@bfirsh after revisiting this comment I realize that instead of commenting out lines of code, the best course of action is to refactor the methods in class RoomApiList. Beforehand, this will require a discussion between members of this repo about how to handle the interactions with the API. Best of luck with this app and hopefully I pointed in the right direction to help fix this bug.