Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App broken after upgrade from 2.0.0 to 2.0.1 #695

Open
villander opened this issue Mar 25, 2024 · 1 comment
Open

App broken after upgrade from 2.0.0 to 2.0.1 #695

villander opened this issue Mar 25, 2024 · 1 comment

Comments

@villander
Copy link

villander commented Mar 25, 2024

Description of the bug:
When I bump the library and run ember s I see this issue

image

My component:

import move from 'ember-animated/motions/move';
import { fadeOut } from 'ember-animated/motions/opacity';
import type Sprite from 'ember-animated/-private/sprite';

export default class NotesNoteBoard extends Component<NotesNoteBoardComponentSignature> {
.....
// eslint-disable-next-line require-yield
  *transition({
    keptSprites,
    removedSprites,
  }: {
    keptSprites: Sprite[];
    removedSprites: Sprite[];
  }) {
    for (const sprite of keptSprites) {
      move(sprite);
    }

    for (const sprite of removedSprites) {
      fadeOut(sprite);
    }
  }
 }

cc @SergeAstapov

@SergeAstapov
Copy link
Collaborator

@villander if you could create minimal reproduction, it would be helpful to figure out the root cause and if it's related to ember-animated addon or something else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants