Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liquid-outlet not working #567

Open
sibijohn72 opened this issue Apr 20, 2017 · 9 comments
Open

liquid-outlet not working #567

sibijohn72 opened this issue Apr 20, 2017 · 9 comments

Comments

@sibijohn72
Copy link

Hi,

The liquid-outlet tag is not working for a simple project i created. I just used the exact same code mentioned in the liquid-fire documentation but none of it comes up in the DOM. There are no errors in my console either.

Ember : 2.11.3 Ember Data : 2.12.2 jQuery : 3.2.1

@FilmKnurd
Copy link
Contributor

Same here Ember : 2.13.3 jQuery : 3.2.1

@ef4
Copy link
Collaborator

ef4 commented Jun 30, 2017

Please try to provide a reproduction. The test suite is running the code from the documentation and it's passing, so there must be something more to it.

@FilmKnurd
Copy link
Contributor

Using Ember CLI 2.13.3

  1. $ ember new firetest
  2. $ ember install liquid-fire
  3. $ ember g route sub
  4. Add transition.js to /app
export default function(){
  this.transition(
    this.fromRoute('index'),
    this.toRoute('sub'),
    this.use('toLeft'),
    this.reverse('toRight')
  );
}
  1. Change /app/templates/application.hbs
{{link-to "Sub Route" "sub"}}

{{liquid-outlet}}
  1. Update /app/templates/sub.hbs
<h1>Sub</h1>
  1. $ ember s
  2. Go to localhost:4200
  3. Click link to sub route
  4. No animation :-(

I've also tried making the from route application and adding duration options

@ef4
Copy link
Collaborator

ef4 commented Jul 1, 2017

Add transition.js to /app

Just realized that's not the right filename, it's app/transitions.js.

@ef4
Copy link
Collaborator

ef4 commented Jul 1, 2017

I think the best way to alleviate this class of problem is to add a default blueprint that generates an app/transitions.js file. That would be a great PR for somebody who wants to give it a go.

@FilmKnurd
Copy link
Contributor

Doh!

I renamed the transitions file... and got this:

loader.js:244 Uncaught Error: Could not find module `liquid-fire/ember-internals` imported from `firestest/initializers/liquid-fire`

@FilmKnurd
Copy link
Contributor

Made the blueprint #579

@FilmKnurd
Copy link
Contributor

I don't know what the issue was. I think something funky with node versions and installed packages. Did a fresh install again on 2.14 and it works fine.

@FilmKnurd
Copy link
Contributor

@sibijohn72 Have you tried again lately. I think this working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants