Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: new Ember app doesn't transition into or out-of broccoli-middleware error page #187

Open
22a opened this issue Mar 3, 2022 · 0 comments

Comments

@22a
Copy link
Member

22a commented Mar 3, 2022

Expected behaviour

  1. I have a working build, the page reloads when I make a change
  2. I introduce a breaking change (eg. template compile error), the page reloads to show the error page with a error description and stack trace (broccoli-middleware)
  3. I fix the breaking change, resulting in a successful rebuild, the page reloads to show the application again

Current behaviour

The below GIF shows a newly generated ember app not reloading to show the ember error page and, once the build error is fixed, not reloading to return to the application.

2022-03-03 15-34-56 2022-03-03 15_41_48

I'm not 100% certain but this feels like a regression, I thought ember apps always transitioned into and out-of the broccoli error page by default.

System info

live-reload-repro main* @ws ⫸ ember --version
ember-cli: 3.28.5
node: 14.15.0
os: linux x64
live-reload-repro main* @ws ⫸ yarn why ember-cli-inject-live-reload
yarn why v1.22.10
[1/4] Why do we have the module "ember-cli-inject-live-reload"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "[email protected]"
info Has been hoisted to "ember-cli-inject-live-reload"
info This module exists because it's specified in "devDependencies".
info Disk size without dependencies: "440KB"
info Disk size with unique dependencies: "812KB"
info Disk size with transitive dependencies: "2.12MB"
info Number of shared dependencies: 11
Done in 1.09s.

Reproduction in an app, but it's just ember new --yarn on [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant