Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Release a version that includes ember-mocha 0.14.0 #259

Open
jbryson3 opened this issue Jun 28, 2018 · 8 comments
Open

Request: Release a version that includes ember-mocha 0.14.0 #259

jbryson3 opened this issue Jun 28, 2018 · 8 comments

Comments

@jbryson3
Copy link

Looking at master's package.json, I was expecting an npm install ember-cli-mocha to give me [email protected] (including the new testing api).

Here's what my npm installed package.json looks like

  "_from": "ember-cli-mocha",
  "_id": "[email protected]",
  "dependencies": {
    "ember-mocha": "^0.13.0"
  },
  "version": "0.15.0"
@Turbo87
Copy link
Member

Turbo87 commented Jun 29, 2018

@jbryson3 there are some changes necessary in this repository before we can release it. mainly we need to update the current ember-cli-mocha blueprint to adjust to the new APIs while preserving support for the old APIs in the migration period. would you like to help move this forward?

@jbryson3
Copy link
Author

I certainly wouldn't mind pitching in, though I'm afraid I don't have the context to do such a PR. Mine would probably be limited to removing start-app, destroy-app, and amending test-helper to what the ember-mocha docs recommend.

@Turbo87
Copy link
Member

Turbo87 commented Jun 30, 2018

@jbryson3 i think that is exactly what is needed, but we will need to test if the new test-helper implementation is still compatible with the old APIs. it might also make sense to keep the old blueprint around with a different name for a while.

@jbryson3
Copy link
Author

jbryson3 commented Jul 8, 2018

#261

@jasonworden
Copy link

Anyone know what those updates may be to those helper files? I am uninstalling and installing [email protected] and having issues

@blimmer
Copy link
Contributor

blimmer commented Sep 18, 2018

@Turbo87 would it be possible to create some "story" tickets so others could help push toward a release?

@Turbo87
Copy link
Member

Turbo87 commented Sep 19, 2018

@blimmer as far as I'm aware all that is needed is #259 (comment)

updating Mocha to a newer version and other refactorings are unrelated to that and not blocking the release of the new API stuff

@mileslane
Copy link

This appears to have been dropped. Any development happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants