Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this package needed anymore? #316

Open
blimmer opened this issue Dec 19, 2018 · 7 comments
Open

Is this package needed anymore? #316

blimmer opened this issue Dec 19, 2018 · 7 comments
Labels

Comments

@blimmer
Copy link
Contributor

blimmer commented Dec 19, 2018

I was talking with @rwjblue at EmberCamp a few months back and I recall him mentioning that this package isn't really necessary anymore. If that's the case, should we update the docs to indicate that?

@Turbo87
Copy link
Member

Turbo87 commented Dec 19, 2018

yes, ember-mocha is mostly ready to be used directly. I was waiting with the official deprecation of this package until ember-mocha was entirely done, but feel free to update the README already.

@blimmer
Copy link
Contributor Author

blimmer commented Dec 19, 2018

What's the remaining work in ember-mocha to make it ready? I can update the README and point those considerations out.

@Turbo87
Copy link
Member

Turbo87 commented Dec 19, 2018

the current state needs to be released, and I need to decide if I want to include emberjs/ember-mocha#284 in the release (which would limit it to Ember CLI 2.13+)

@blimmer
Copy link
Contributor Author

blimmer commented Dec 19, 2018

Gotcha - that makes sense. Since ember-mocha is still 0.x.x, a minor release (0.15.0) would indicate a breaking change that could be documented in the README.

What are you thinking for the timing of that release. If it's going to be soonish, I can wait for my PR to the README.

@Turbo87
Copy link
Member

Turbo87 commented Dec 19, 2018

What are you thinking for the timing of that release.

Ideally it should have been released in April, but I was busy with other stuff and kept getting distracted... 😞

@mileslane
Copy link

What are you thinking for the timing of that release.

Ideally it should have been released in April, but I was busy with other stuff and kept getting distracted... 😞

And now?

@mileslane
Copy link

Asking again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants