Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Deprecate npmOptions and buildManagerOptions options in favor of a single packageManagerInstallOptions option #1047

Open
bertdeblock opened this issue Jan 3, 2025 · 0 comments

Comments

@bertdeblock
Copy link
Member

bertdeblock commented Jan 3, 2025

packageManagerInstallOptions is more in line with the new packageManager option.

packageManagerInstallOptions type:

packageManagerInstallOptions: string[] | (defaultOptions: string[], scenario: Scenario) => string[];

When the user provides string[], we don't include the default options like we do now. If the user wants to make sure the default options are included as well, they must provide a function and spread in the default options manually.

@bertdeblock bertdeblock changed the title Deprecate npmOptions and buildManagerOptions options in favor of a single packageManagerOptions option Deprecate npmOptions and buildManagerOptions options in favor of a single packageManagerInstallOptions option Jan 3, 2025
@bertdeblock bertdeblock changed the title Deprecate npmOptions and buildManagerOptions options in favor of a single packageManagerInstallOptions option [Suggestion] Deprecate npmOptions and buildManagerOptions options in favor of a single packageManagerInstallOptions option Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant