Skip to content

Move helper disambiguation to a flag that is off by default #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mansona opened this issue Feb 1, 2024 · 0 comments · Fixed by #515
Closed

Move helper disambiguation to a flag that is off by default #514

mansona opened this issue Feb 1, 2024 · 0 comments · Fixed by #515
Assignees

Comments

@mansona
Copy link
Member

mansona commented Feb 1, 2024

With #509 we introduced the ability to disambiguate helper calls by wrapping {{some-helper}} in round brackets like this {{(some-helper)}}. This helps in an embroider build but there is a bug somewhere in the stack with a classic build that causes this to fail at runtime.

We need to hide this functionality behind a flag so that people can opt-into it if it's something that they need/want i.e. if they are running embroider and wanting to turn on staticHelper and staticModifiers without turning on staticComponents 👍

lolmaus added a commit to lolmaus/ember-angle-brackets-codemod that referenced this issue Feb 6, 2024
lolmaus added a commit to lolmaus/ember-angle-brackets-codemod that referenced this issue Feb 6, 2024
@lolmaus lolmaus moved this from Todo to In Progress in Mainmatter Embroider Team Feb 6, 2024
lolmaus added a commit to lolmaus/ember-angle-brackets-codemod that referenced this issue Feb 6, 2024
lolmaus added a commit to lolmaus/ember-angle-brackets-codemod that referenced this issue Feb 6, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Mainmatter Embroider Team Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants