Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native-dom leaves unused selectors find & findAll #34

Open
tmquinn opened this issue Jan 15, 2019 · 2 comments
Open

native-dom leaves unused selectors find & findAll #34

tmquinn opened this issue Jan 15, 2019 · 2 comments

Comments

@tmquinn
Copy link

tmquinn commented Jan 15, 2019

When native-dom transforms find(selector, context) or findAll(selector, context) the (now) unused specifiers remain in the import statement

@tmquinn tmquinn changed the title native-dom-helpers-test should not transform find & findAll ember-native-dom-helpers should not transform find & findAll Jan 15, 2019
@tmquinn tmquinn changed the title ember-native-dom-helpers should not transform find & findAll native-dom should not transform find & findAll Jan 15, 2019
@tmquinn
Copy link
Author

tmquinn commented Jan 16, 2019

ok, I think it is only transforming find(selector, context), but the actual issue is that it does not remove the selectors from the import

@tmquinn tmquinn changed the title native-dom should not transform find & findAll native-dom leaves unused selectors find & findAll Jan 16, 2019
@simonihmig
Copy link
Collaborator

As you can see in the tests here, it should convert the imports, and prune unused ones.

Could you provide an example, where this does not work? Or even better a PR that leads to a failing test? (you just need to add a pair of *.input.js and *.output.js fixtures, with the output being the expected one!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants